netdev - Re: [PATCH -next] net: dsa: mv88e6xxx: fix non static symbol warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87fuon1zdw.fsf@ketchup.i-did-not-set--mail-host-address--so-tickle-me>
Date:   Sun, 25 Sep 2016 16:46:19 -0400
From:   Vivien Didelot <vivien.didelot@...oirfairelinux.com>
To:     Wei Yongjun <weiyj.lk@...il.com>, Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>
Cc:     Wei Yongjun <weiyongjun1@...wei.com>, netdev@...r.kernel.org
Subject: Re: [PATCH -next] net: dsa: mv88e6xxx: fix non static symbol warnings

Hi Wei,

Wei Yongjun <weiyj.lk@...il.com> writes:

> From: Wei Yongjun <weiyongjun1@...wei.com>
>
> Fixes the following sparse warnings:
>
> drivers/net/dsa/mv88e6xxx/chip.c:219:5: warning:
>  symbol 'mv88e6xxx_port_read' was not declared. Should it be static?
> drivers/net/dsa/mv88e6xxx/chip.c:227:5: warning:
>  symbol 'mv88e6xxx_port_write' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>

Reviewed-by: Vivien Didelot <vivien.didelot@...oirfairelinux.com>

Thanks,

        Vivien