netdev - Re: [PATCH net v2 0/2] Fix tc-ife bugs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2b01c982-76b7-d380-807c-1fe1df62d285@mojatatu.com>
Date:   Sun, 25 Sep 2016 09:46:25 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Yotam Gigi <yotam.gi@...il.com>, davem@...emloft.net,
        netdev@...r.kernel.org, yotamg@...lanox.com
Subject: Re: [PATCH net v2 0/2] Fix tc-ife bugs

On 16-09-25 08:31 AM, Yotam Gigi wrote:
> This patch-set contains two bugfixes in the tc-ife action, one fixing some
> random behaviour in encode side, and one fixing the decode side packet
> parsing logic.
>
> Yotam Gigi (2):
>   act_ife: Fix external mac header on encode
>   act_ife: Fix false parsing on decode side
>
>  net/sched/act_ife.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
>

Yotam, did you run the test i proposed? I am worried about the TLV one.
Note:
Encoder includes the length of the TLV header length in the L part.
If you are reaching a conclusion that you need this in the decoding:
+		tlvdata += alen + sizeof(struct meta_tlvhdr);

then very likely whoever is sending that packet is not encoding
correctly.

cheers,
jamal