netdev - Re: [PATCH v5 00/16] Add Paravirtual RDMA Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 26 Sep 2016 13:40:10 -0700
From:   Adit Ranadive <aditr@...are.com>
To:     Jason Gunthorpe <jgunthorpe@...idianresearch.com>
CC:     Leon Romanovsky <leon@...nel.org>, <dledford@...hat.com>,
        <linux-rdma@...r.kernel.org>, <pv-drivers@...are.com>,
        <netdev@...r.kernel.org>, <linux-pci@...r.kernel.org>,
        <jhansen@...are.com>, <asarwade@...are.com>,
        <georgezhang@...are.com>, <bryantan@...are.com>
Subject: Re: [PATCH v5 00/16] Add Paravirtual RDMA Driver

On Mon, Sep 26, 2016 at 10:51:04AM -0600, Jason Gunthorpe wrote:
> On Sun, Sep 25, 2016 at 10:25:12PM -0700, Adit Ranadive wrote:
> > > As Jason said, you need a very good reason to split and create number of
> > > files per-driver in UAPI folder.
> > 
> > I can move the pvrdma-uapi.h back to the pvrdma driver folder.
> 
> Just don't copy any of the content into your user space provider.

Thanks. I wanted to clarify regarding device specific structures since that
is what our pvrdma-uapi.h file has.

Wouldnt they be some overlap between the user-space and kernel driver? Or is
it expected that the common structures (even device specific ones) be moved to
the ABI file?

For the mlx4 driver I see that the structures in include/linux/mlx4/qp.h
and in libmlx4/src/wqe.h are similar.

Thanks,
Adit