netdev - Re: [PATCH] net: trivial: fix fsl fec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7f2ef23b-7354-2049-9747-cdaf4109b5a0@cogentembedded.com>
Date:   Tue, 27 Sep 2016 01:10:14 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     "Albert ARIBAUD (3ADEV)" <albert.aribaud@...ev.fr>,
        netdev@...r.kernel.org
Cc:     Jiri Kosina <trivial@...nel.org>, Fugang Duan <fugang.duan@....com>
Subject: Re: [PATCH] net: trivial: fix fsl fec_main mdio write return value

Hello.

On 09/26/2016 10:11 PM, Albert ARIBAUD (3ADEV) wrote:

> If the MDIO enf-of-transfer wait loop does not time out,
> 0 should be returned to the caller through ret, but ret
> was not reset to 0 after receiving the return value of
> pm_runtime_get_sync(). Reset ret when no time out occurred.
>
> Signed-off-by: Albert ARIBAUD (3ADEV) <albert.aribaud@...ev.fr>
> ---
>  drivers/net/ethernet/freescale/fec_main.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
> index 01f7e81..0413c05 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -1818,6 +1818,8 @@ static int fec_enet_mdio_write(struct mii_bus *bus, int mii_id, int regnum,
>  		netdev_err(fep->netdev, "MDIO write timeout\n");
>  		ret  = -ETIMEDOUT;
>  	}
> +	else

	} else {

> +		ret = 0;

	}

[...]

MBR, Sergei