netdev - Re: [PATCH] fs/select: add vmalloc fallback for select(2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <92d1ec2c-3246-bd1f-eae5-53ca425ab315@suse.cz>
Date:   Tue, 27 Sep 2016 13:51:03 +0200
From:   Vlastimil Babka <vbabka@...e.cz>
To:     Nicholas Piggin <npiggin@...il.com>,
        David Laight <David.Laight@...LAB.COM>
Cc:     Jason Baron <jbaron@...mai.com>,
        Hillf Danton <hillf.zj@...baba-inc.com>,
        'Alexander Viro' <viro@...iv.linux.org.uk>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        'Michal Hocko' <mhocko@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH] fs/select: add vmalloc fallback for select(2)

On 09/27/2016 01:42 PM, Nicholas Piggin wrote:
> On Tue, 27 Sep 2016 11:37:24 +0000
> David Laight <David.Laight@...LAB.COM> wrote:
>
>> From: Nicholas Piggin
>> > Sent: 27 September 2016 12:25
>> > On Tue, 27 Sep 2016 10:44:04 +0200
>> > Vlastimil Babka <vbabka@...e.cz> wrote:
>> >
>> >
>> > What's your customer doing with those selects? If they care at all about
>> > performance, I doubt they want select to attempt order-4 allocations, fail,
>> > then use vmalloc :)
>>
>> If they care about performance they shouldn't be passing select() lists that
>> are anywhere near that large.
>> If the number of actual fd is small - use poll().
>
> Right. Presumably it's some old app they're still using, no?

Process name suggests it's part of db2 database. It seems it has to implement 
its own interface to select() syscall, because glibc itself seems to have a 
FD_SETSIZE limit of 1024, which is probably why this wasn't an issue for all the 
years...