netdev - Re: [PATCH v4 2/7] proc: Reduce cache miss in snmp_seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160927.094551.1178979867316917587.davem@davemloft.net>
Date:   Tue, 27 Sep 2016 09:45:51 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     hejianet@...il.com
Cc:     netdev@...r.kernel.org, linux-sctp@...r.kernel.org,
        linux-kernel@...r.kernel.org, kuznet@....inr.ac.ru,
        jmorris@...ei.org, yoshfuji@...ux-ipv6.org, kaber@...sh.net,
        vyasevich@...il.com, nhorman@...driver.com,
        steffen.klassert@...unet.com, herbert@...dor.apana.org.au,
        marcelo.leitner@...il.com
Subject: Re: [PATCH v4 2/7] proc: Reduce cache miss in snmp_seq_show

From: Jia He <hejianet@...il.com>
Date: Mon, 26 Sep 2016 16:09:10 +0800

> +static int snmp_seq_show_tcp_udp(struct seq_file *seq, void *v)
> +{
> +	int i;
> +	unsigned long buff[TCPUDP_MIB_MAX];
> +	struct net *net = seq->private;

Please always order local variables from longest to shortest
line.

Please audit your entire patch series for this problem.

Thanks.