netdev - Re: [PATCH v3 net-next] net: phy: Add Edge-rate driver for Microsemi PHYs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160927141633.GJ28432@lunn.ch>
Date:   Tue, 27 Sep 2016 16:16:33 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Raju Lakkaraju <Raju.Lakkaraju@...rosemi.com>
Cc:     netdev@...r.kernel.org, devicetree@...r.kernel.org,
        f.fainelli@...il.com, Allan.Nielsen@...rosemi.com
Subject: Re: [PATCH v3 net-next] net: phy: Add Edge-rate driver for Microsemi
 PHYs.

> index 0000000..7ba3855
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt
> @@ -0,0 +1,61 @@
> +* Microsemi - vsc8531 Giga bit ethernet phy
> +
> +Required properties:
> +- compatible	: Should contain phy id as "ethernet-phy-idAAAA.BBBB"
> +		  If the phy's identifier is known then the list may contain an entry
> +		  of the form: "ethernet-phy-idAAAA.BBBB" where
> +		  AAAA - The value of the 16 bit Phy Identifier 1 register as
> +			 4 hex digits. This is the chip vendor OUI bits 3:18
> +		  BBBB - The value of the 16 bit Phy Identifier 2 register as
> +			 4 hex digits. This is the chip vendor OUI bits 19:24,
> +			 followed by 10 bits of a vendor specific ID.
> +- reg		: The ID number for the phy, usually a small integer

Please don't copy phy.txt. Just refer to it. Use text like:

The PHY device uses the binding described in
Documentation/devicetree/bindings/net/phy.txt

It may additionally have the following properties

> +Optional properties:
> +- vsc8531,edge-rate	: Edge rate sets the drive strength of the MAC
> +			  interface output signals.  Changing the drive
> +			  strength will affect the edge rate of the output
> +			  signal.

Are we specifying a rate or a strength? It is called edge-rate, so it
expect it to be a rate, mV/pS or something similar.

       Andrew