netdev - Re: [RFC PATCH net-next 2/2] sfc: report 4-tuple UDP hashing to ethtool, if it's enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 27 Sep 2016 18:12:13 +0000
From:   "Mintz, Yuval" <Yuval.Mintz@...ium.com>
To:     Edward Cree <ecree@...arflare.com>,
        "linux-net-drivers@...arflare.com" <linux-net-drivers@...arflare.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "bkenward@...arflare.com" <bkenward@...arflare.com>
Subject: Re: [RFC PATCH net-next 2/2] sfc: report 4-tuple UDP hashing to
 ethtool, if it's enabled

>                  info->data = 0;
>                  switch (info->flow_type) {
> +               case UDP_V4_FLOW:
> +                       if (efx->rx_hash_udp_4tuple)
> +                               /* fall through */
> +                       /* else fall further! */
>                  case TCP_V4_FLOW:
> -                       info->data |= RXH_L4_B_0_1 | RXH_L4_B_2_3;
> +                               info->data |= RXH_L4_B_0_1 | RXH_L4_B_2_3;
>                          /* fall through */
> -               case UDP_V4_FLOW:
>                  case SCTP_V4_FLOW:
>                  case AH_ESP_V4_FLOW:
>                  case IPV4_FLOW:
>                          info->data |= RXH_IP_SRC | RXH_IP_DST;
>                          min_revision = EFX_REV_FALCON_B0;
>                          break;

Well, you sure fulfilled your cover letter's promise. ;-)

Do you really prefer this conditional mayham over copy-pasting some lines?