lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 27 Sep 2016 10:25:36 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> Cc: SF Markus Elfring <elfring@...rs.sourceforge.net>, gigaset307x-common@...ts.sourceforge.net, netdev@...r.kernel.org, Karsten Keil <isdn@...ux-pingi.de>, Paul Bolle <pebolle@...cali.nl>, LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org, Julia Lawall <julia.lawall@...6.fr> Subject: Re: [PATCH 5/5] ISDN-Gigaset: Enclose two expressions for the sizeof operator by parentheses On Tue, Sep 27, 2016 at 10:08:37AM +0300, Dan Carpenter wrote: > On Mon, Sep 26, 2016 at 08:38:14PM +0300, Sergei Shtylyov wrote: > > >@@ -53,7 +53,7 @@ void gigaset_dbg_buffer(enum debuglevel level, const unsigned char *msg, > > > { > > > unsigned char outbuf[80]; > > > unsigned char c; > > >- size_t space = sizeof outbuf - 1; > > >+ size_t space = sizeof(outbuf - 1); > > > > What?! Does that compile? > > > > [...] > > It prints a Smatch warning. Smatch ignores these if they happen inside > a macro where you pass a pointer and it takes the sizeof() the argument. Reading that again, I realize it's not clear. Smatch ignores these any time they happen in a macro whether they're valid or not. (Many times they are valid). regards, dan carpenter
Powered by blists - more mailing lists