netdev - Re: [Gigaset307x-common] ISDN-Gigaset: Release memory in gigaset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5974a2c5-2739-cd69-6e37-04a645bc08d7@users.sourceforge.net>
Date:   Tue, 27 Sep 2016 13:32:38 +0200
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     Tilman Schmidt <tilman@...p.cc>
Cc:     Paul Bolle <pebolle@...cali.nl>,
        Karsten Keil <isdn@...ux-pingi.de>,
        gigaset307x-common@...ts.sourceforge.net, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>,
        Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [Gigaset307x-common] ISDN-Gigaset: Release memory in
 gigaset_initcs() after an allocation failure

>> I got the impression that the exception handling  was incomplete in the
>> implementation of the function "gigaset_initcs".
> 
> That impression is wrong. Careful reading of the code will confirm that.

* Is it still correct nowadays that the function "gigaset_initcs" did not
  call the function "kfree" after a later function call failed?

* Do you expect that allocated memory will be automatically reclaimed
  after it would return a null pointer?

Regards,
Markus