netdev - Re: [PATCH v3 net-next 0/3] net: bcmgenet: only use new api ethtool_{get|set}_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160927.074342.1048165536305147870.davem@davemloft.net>
Date:   Tue, 27 Sep 2016 07:43:42 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     tremyfr@...il.com
Cc:     f.fainelli@...il.com, jaedon.shin@...il.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 net-next 0/3] net: bcmgenet: only use new api
 ethtool_{get|set}_link_ksettings

From: Philippe Reynes <tremyfr@...il.com>
Date: Mon, 26 Sep 2016 22:31:54 +0200

> Some times ago, a serie of patches were committed :
> - commit 62469c76007e ("net: ethernet: bcmgenet: use phydev from struct net_device")
> - commit 6b352ebccbcf ("net: ethernet: broadcom: bcmgenet: use new api ethtool_{get|set}_link_ksettings")
> The first patch add a regression on this driver, so it should be reverted.
> As the second patch depend on the former, it should be reverted too.
> 
> The first patch is buggy because there is a "trick" in this driver.
> The structure phydev is kept in the private data when the interface
> go down, and used when the interface go up to enable the phy before
> the function phy_connect is called.
> 
> I don't have this hardware, neither the datasheet. So I won't
> update the driver to avoid this trick.
> 
> But the real goal of the first serie was to move to the new api
> ethtool_{get|set}_link_ksettings. So I provide a new version of
> the patch without the "cleaning" of driver to use the phydev
> store in the net_device structure.
> 
> Changelog:
> v3:
> - use priv instead of dev (so all the code use the same phydev)
> v2:
> - use Florian Fainelli patches for the revert instead of Jaedon Shin
> - simply use net: bcmgenet: for the prefix of the patch

Series applied, thanks.