netdev - Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5c1cff4e-25bc-5356-a8f8-f5fa44b2a439@mojatatu.com>
Date:   Wed, 28 Sep 2016 08:50:31 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Cyrill Gorcunov <gorcunov@...il.com>
Cc:     David Miller <davem@...emloft.net>, eric.dumazet@...il.com,
        dsa@...ulusnetworks.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, kuznet@....inr.ac.ru,
        jmorris@...ei.org, yoshfuji@...ux-ipv6.org, kaber@...sh.net,
        avagin@...nvz.org, stephen@...workplumber.org
Subject: Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

On 16-09-28 08:45 AM, Cyrill Gorcunov wrote:

>> Note: inet_diag somewhere has a netlink structure that
>> has a hole. I pointed it out to Eric D. and he said we cant
>> add it now because it would break ABI.
>
> Naming holes generated by a compiler for alignment sake should
> not break abi (because alignments are abi by self), but I may
> be missing something in context of where the structure you're
> talking about is present. And what about non-x86 archs? They
> might have different members alignment requirements.
>

struct tcp_info.

Sorry - i didnt mean to drag this for long; but the more i think
about it, the union is a pragmatic approach.

cheers,
jamal