netdev - Re: [PATCH v3 net-next] tcp: Change txhash on every SYN and RTO retransmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <D4109D86.1F361%brakmo@fb.com>
Date:   Wed, 28 Sep 2016 05:07:16 +0000
From:   Lawrence Brakmo <brakmo@...com>
To:     Neal Cardwell <ncardwell@...gle.com>,
        Yuchung Cheng <ycheng@...gle.com>
CC:     netdev <netdev@...r.kernel.org>, Kernel Team <Kernel-team@...com>,
        "Eric Dumazet" <eric.dumazet@...il.com>
Subject: Re: [PATCH v3 net-next] tcp: Change txhash on every SYN and RTO
 retransmit

Neal and Yuchung, thank you for the feedback. I¹ve submitted v4 with your
recommended changes.

Thanks,
Larry

On 9/27/16, 6:28 PM, "Neal Cardwell" <ncardwell@...gle.com> wrote:

>On Tue, Sep 27, 2016 at 8:18 PM, Yuchung Cheng <ycheng@...gle.com> wrote:
>> On Tue, Sep 27, 2016 at 4:31 PM, Lawrence Brakmo <brakmo@...com> wrote:
>>> @@ -213,6 +215,8 @@ static int tcp_write_timeout(struct sock *sk)
>>>                         tcp_mtu_probing(icsk, sk);
>>>
>>>                         dst_negative_advice(sk);
>>> +               } else if (prandom_u32_max(100) <
>>>sysctl_tcp_rto_txhash_prob) {
>> The sysctl is not really needed but that's just my opinion.
>
>I agree that it sounds nice to simplify by not having a sysctl for
>this and always calling sk_rethink_txhash() here.
>
>neal