netdev - Re: [patch net-next v3 0/6] fib offload: switch to notifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160928.044930.430080084052194610.davem@davemloft.net>
Date:   Wed, 28 Sep 2016 04:49:30 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     jiri@...nulli.us
Cc:     netdev@...r.kernel.org, idosch@...lanox.com, eladr@...lanox.com,
        yotamg@...lanox.com, nogahf@...lanox.com, ogerlitz@...lanox.com,
        roopa@...ulusnetworks.com, nikolay@...ulusnetworks.com,
        linville@...driver.com, andy@...yhouse.net, f.fainelli@...il.com,
        dsa@...ulusnetworks.com, jhs@...atatu.com,
        vivien.didelot@...oirfairelinux.com, andrew@...n.ch,
        ivecera@...hat.com, kaber@...sh.net, john@...ozen.org
Subject: Re: [patch net-next v3 0/6] fib offload: switch to notifier

From: Jiri Pirko <jiri@...nulli.us>
Date: Mon, 26 Sep 2016 12:52:28 +0200

> The goal of this patchset is to allow driver to propagate all prefixes
> configured in kernel down HW. This is necessary for routing to work
> as expected. If we don't do that HW might forward prefixes known to kernel
> incorrectly. Take an example when default route is set in switch HW and there
> is an IP address set on a management (non-switch) port.
> 
> Currently, only FIB entries related to the switch port netdev are
> offloaded using switchdev ops. This model is not extendable so the
> first patch introduces a replacement: notifier to propagate FIB entry
> additions and removals to whoever is interested.

Although I am disappointed that we need to use notifiers to support
fib offloading properly (it seems ad-hoc and hackish), I cannot come
up with a better solution to the problem. :-)

So series applied, thanks Jiri!