netdev - Re: [RFC v2 2/4] staging: rtl8712: Change _LED_STATE enum in rtl871x driver to avoid conflicts with LED namespace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160928092741.GA16646@kroah.com>
Date:   Wed, 28 Sep 2016 11:27:41 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Zach Brown <zach.brown@...com>
Cc:     f.fainelli@...il.com, devel@...verdev.osuosl.org,
        florian.c.schilhabel@...glemail.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Larry.Finger@...inger.net,
        mlindner@...vell.com
Subject: Re: [RFC v2 2/4] staging: rtl8712: Change _LED_STATE enum in rtl871x
 driver to avoid conflicts with LED namespace

On Tue, Sep 27, 2016 at 04:51:49PM -0500, Zach Brown wrote:
> Adding led support for phy causes namespace conflicts for some
> phy drivers.
> 
> The rtl871 driver declared an enum for representing LED states. The enum
> contains constant LED_OFF which conflicted with declaration found in
> linux/leds.h. LED_OFF changed to LED_STATE_OFF
> In order to avoid a possible future collision LED_ON was changed to
> LED_STATE_ON as well.
> 
> Signed-off-by: Zach Brown <zach.brown@...com>
> ---
>  drivers/staging/rtl8712/rtl8712_led.c | 388 +++++++++++++++++-----------------
>  1 file changed, 194 insertions(+), 194 deletions(-)

Ick, messy.  I'll be glad to take this patch now to make your life
easier in the future.

thanks,

greg k-h