netdev - Re: [PATCH net-next v3] netfilter: xt_hashlimit: Fix link error in 32bit arch because of 64bit division

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 30 Sep 2016 10:53:20 +0900
From:   Maciej Żenczykowski <maze@...gle.com>
To:     Vishwanath Pai <vpai@...mai.com>
Cc:     Pablo Neira Ayuso <pablo@...filter.org>, johunt@...mai.com,
        netfilter-devel@...r.kernel.org, coreteam@...filter.org,
        Linux NetDev <netdev@...r.kernel.org>,
        Vishwanath Pai <pai.vishwain@...il.com>,
        Patrick McHardy <kaber@...sh.net>, kadlec@...ckhole.kfki.hu,
        zlpnobody@...il.com,
        Hannes Frederic Sowa <hannes@...essinduktion.org>,
        Eric Dumazet <eric.dumazet@...il.com>,
        akpm@...ux-foundation.org
Subject: Re: [PATCH net-next v3] netfilter: xt_hashlimit: Fix link error in
 32bit arch because of 64bit division

> +               return div64_u64((user * HZ * CREDITS_PER_JIFFY_v1),
> +                                XT_HASHLIMIT_SCALE);

spurious ()

> +               return div64_u64((user * HZ * CREDITS_PER_JIFFY),
> +                                XT_HASHLIMIT_SCALE_v2);

spurious ()

but:

Acked-by: Maciej Żenczykowski