netdev - Re: [PATCH net-next v2 2/3] mpls: move mpls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 30 Sep 2016 10:43:42 -0700
From:   pravin shelar <pshelar@....org>
To:     Jiri Benc <jbenc@...hat.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        David Ahern <dsa@...ulusnetworks.com>
Subject: Re: [PATCH net-next v2 2/3] mpls: move mpls_hdr to a common location

On Fri, Sep 30, 2016 at 10:08 AM, Jiri Benc <jbenc@...hat.com> wrote:
> This will be also used by openvswitch.
>
> Signed-off-by: Jiri Benc <jbenc@...hat.com>
> ---
> v2: new in v2
> ---
>  include/net/mpls.h  |  9 +++++++++
>  net/mpls/internal.h | 10 +---------
>  2 files changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/include/net/mpls.h b/include/net/mpls.h
> index 5b3b5addfb08..3ebbc0bb57ff 100644
> --- a/include/net/mpls.h
> +++ b/include/net/mpls.h
> @@ -19,12 +19,21 @@
>
>  #define MPLS_HLEN 4
>
> +struct mpls_shim_hdr {
> +       __be32 label_stack_entry;
> +};
> +
There is already struct mpls_label defined in uapi mpls header file.
Is there reason for not using it here?