netdev - Re: [PATCH net-next v3] netfilter: xt_hashlimit: Fix link error in 32bit arch because of 64bit division

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <57EEA7AB.3010301@akamai.com>
Date:   Fri, 30 Sep 2016 13:58:03 -0400
From:   Vishwanath Pai <vpai@...mai.com>
To:     Pablo Neira Ayuso <pablo@...filter.org>
Cc:     johunt@...mai.com, netfilter-devel@...r.kernel.org,
        coreteam@...filter.org, netdev@...r.kernel.org,
        pai.vishwain@...il.com, kaber@...sh.net, kadlec@...ckhole.kfki.hu,
        zlpnobody@...il.com, hannes@...essinduktion.org, maze@...gle.com,
        eric.dumazet@...il.com, akpm@...ux-foundation.org
Subject: Re: [PATCH net-next v3] netfilter: xt_hashlimit: Fix link error in
 32bit arch because of 64bit division

On 09/30/2016 01:46 PM, Pablo Neira Ayuso wrote:
> On Thu, Sep 29, 2016 at 01:39:50PM -0400, Vishwanath Pai wrote:
>> v2:
>> Remove unnecessary div64_u64 around constants
>>
>> v3:
>> remove backslashes
>>
>> --
>>
>> Fix link error in 32bit arch because of 64bit division
>>
>> Division of 64bit integers will cause linker error undefined reference
>> to `__udivdi3'. Fix this by replacing divisions with div64_64
> 
> Applied, thanks Pai.
> 
>> Signed-off-by: Vishwanath Pai <vpai@...mai.com>
>> Fixes: 11d5f15723c9 ("netfilter: xt_hashlimit: Create revision 2 to ...")
>>
>> ---
> 
> Please, next time place the versioning information here, otherwise git
> am takes the wrong description here.
> 

Thank you. And sorry about, I did not realize git am would put that into
the description.

-Vishwanath