netdev - Re: [PATCH] rxrpc: split up rxrpc_send_call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 01 Oct 2016 10:15:15 +0100
From:   David Howells <dhowells@...hat.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     dhowells@...hat.com, "David S. Miller" <davem@...emloft.net>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rxrpc: split up rxrpc_send_call_packet()

Arnd Bergmann <arnd@...db.de> wrote:

> Yes, good idea. We could probably share the part of the two functions that
> sets the contents of the msg and pkt variables by moving it into a third
> function, but I'm not sure if that actually improves readability or just
> reduces the number of lines.

And the ACK-sending function is about to get a bit more complex :-(

David