netdev - Re: [PATCH] ipv6 addrconf: remove addrconf_sysctl_hop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161002.234831.149876659535482615.davem@davemloft.net>
Date:   Sun, 02 Oct 2016 23:48:31 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     zenczykowski@...il.com
Cc:     maze@...gle.com, netdev@...r.kernel.org, ek@...gle.com,
        lorenzo@...gle.com
Subject: Re: [PATCH] ipv6 addrconf: remove addrconf_sysctl_hop_limit()

From: Maciej Żenczykowski <zenczykowski@...il.com>
Date: Thu, 29 Sep 2016 00:33:43 -0700

> From: Maciej Żenczykowski <maze@...gle.com>
> 
> This is an effective no-op in terms of user observable behaviour.
> 
> By preventing the overwrite of non-null extra1/extra2 fields
> in addrconf_sysctl() we can enable the use of proc_dointvec_minmax().
> 
> This allows us to eliminate the constant min/max (1..255) trampoline
> function that is addrconf_sysctl_hop_limit().
> 
> This is nice because it simplifies the code, and allows future
> sysctls with constant min/max limits to also not require trampolines.
> 
> We still can't eliminate the trampoline for mtu because it isn't
> actually a constant (it depends on other tunables of the device)
> and thus requires at-write-time logic to enforce range.
> 
> Signed-off-by: Maciej Żenczykowski <maze@...gle.com>

Applied, thanks.