netdev - Re: [Xen-devel] [PATCH v2 net-next 4/7] xen-netback: immediately wake tx queue when guest rx queue has space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161004124854.GD30836@localhost.localdomain>
Date:   Tue, 4 Oct 2016 08:48:55 -0400
From:   Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To:     Paul Durrant <paul.durrant@...rix.com>
Cc:     netdev@...r.kernel.org, xen-devel@...ts.xenproject.org,
        Wei Liu <wei.liu2@...rix.com>,
        David Vrabel <david.vrabel@...rix.com>
Subject: Re: [Xen-devel] [PATCH v2 net-next 4/7] xen-netback: immediately
 wake tx queue when guest rx queue has space

On Tue, Oct 04, 2016 at 02:29:15AM -0700, Paul Durrant wrote:
> From: David Vrabel <david.vrabel@...rix.com>
> 
> When an skb is removed from the guest rx queue, immediately wake the
> tx queue, instead of after processing them.

Please, could the description explain why?

> 
> Signed-off-by: David Vrabel <david.vrabel@...rix.com>
> [re-based]
> Signed-off-by: Paul Durrant <paul.durrant@...rix.com>
> ---
> Cc: Wei Liu <wei.liu2@...rix.com>
> ---
>  drivers/net/xen-netback/rx.c | 24 ++++++++----------------
>  1 file changed, 8 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/net/xen-netback/rx.c b/drivers/net/xen-netback/rx.c
> index b0ce4c6..9548709 100644
> --- a/drivers/net/xen-netback/rx.c
> +++ b/drivers/net/xen-netback/rx.c
> @@ -92,27 +92,21 @@ static struct sk_buff *xenvif_rx_dequeue(struct xenvif_queue *queue)
>  	spin_lock_irq(&queue->rx_queue.lock);
>  
>  	skb = __skb_dequeue(&queue->rx_queue);
> -	if (skb)
> +	if (skb) {
>  		queue->rx_queue_len -= skb->len;
> +		if (queue->rx_queue_len < queue->rx_queue_max) {
> +			struct netdev_queue *txq;
> +
> +			txq = netdev_get_tx_queue(queue->vif->dev, queue->id);
> +			netif_tx_wake_queue(txq);
> +		}
> +	}
>  
>  	spin_unlock_irq(&queue->rx_queue.lock);
>  
>  	return skb;
>  }
>  
> -static void xenvif_rx_queue_maybe_wake(struct xenvif_queue *queue)
> -{
> -	spin_lock_irq(&queue->rx_queue.lock);
> -
> -	if (queue->rx_queue_len < queue->rx_queue_max) {
> -		struct net_device *dev = queue->vif->dev;
> -
> -		netif_tx_wake_queue(netdev_get_tx_queue(dev, queue->id));
> -	}
> -
> -	spin_unlock_irq(&queue->rx_queue.lock);
> -}
> -
>  static void xenvif_rx_queue_purge(struct xenvif_queue *queue)
>  {
>  	struct sk_buff *skb;
> @@ -585,8 +579,6 @@ int xenvif_kthread_guest_rx(void *data)
>  		 */
>  		xenvif_rx_queue_drop_expired(queue);
>  
> -		xenvif_rx_queue_maybe_wake(queue);
> -
>  		cond_resched();
>  	}
>  
> -- 
> 2.1.4
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@...ts.xen.org
> https://lists.xen.org/xen-devel