netdev - Re: [PATCH] vmxnet3: Wake queue from reset work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161004.003640.2123697293503989553.davem@davemloft.net>
Date:   Tue, 04 Oct 2016 00:36:40 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     bpoirier@...e.com
Cc:     netdev@...r.kernel.org, skhare@...are.com, pv-drivers@...are.com
Subject: Re: [PATCH] vmxnet3: Wake queue from reset work

From: Benjamin Poirier <bpoirier@...e.com>
Date: Mon,  3 Oct 2016 10:47:50 +0800

> vmxnet3_reset_work() expects tx queues to be stopped (via
> vmxnet3_quiesce_dev -> netif_tx_disable). However, this races with the
> netif_wake_queue() call in netif_tx_timeout() such that the driver's
> start_xmit routine may be called unexpectedly, triggering one of the BUG_ON
> in vmxnet3_map_pkt with a stack trace like this:
 ...
> Signed-off-by: Benjamin Poirier <bpoirier@...e.com>

Applied, thanks.