netdev - Re: [PATCH] ipv6 addrconf: disallow rtr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANP3RGdVquyFe1VA2mKMC1HNgnXPhmpsv45R-7P6boWCb8oC2A@mail.gmail.com>
Date:   Tue, 4 Oct 2016 15:40:30 +0900
From:   Maciej Żenczykowski <zenczykowski@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     Linux NetDev <netdev@...r.kernel.org>, Erik Kline <ek@...gle.com>,
        Lorenzo Colitti <lorenzo@...gle.com>
Subject: Re: [PATCH] ipv6 addrconf: disallow rtr_solicits < -1

> Please remove the const qualifier and the casts to be consistent
> with how we handle this elsewhere.
>
> Thanks.

I can of course trivially make that change.

But:

(on net-next/master)
git grep 'extra[12].*=.*\(void *[*]\)'

currently finds 45 matches, and this patch adds a 46th.

In particular there's a ton of such examples in:
  drivers/parport/procfs.c
  kernel/sysctl.c
  net/rxrpc/sysctl.c
  security/keys/sysctl.c

There's also the 2 that were added to:
  net/ipv6/addrconf.c (ie. same file as this patch)
in my previous patch set.

Should I also remove void * from those as well?

Should this be left as is?

Marking it explicitly as const gets the constants into the rodata
section which is cpu page table masked to be read-only so it seems
much safer/better...

- Maciej