netdev - Re: [PATCH net-next v2 1/3] openvswitch: normalize vlan rx path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161005210709.79732b27@griffin>
Date:   Wed, 5 Oct 2016 21:07:09 +0200
From:   Jiri Benc <jbenc@...hat.com>
To:     Eric Garver <e@...g.me>
Cc:     Eyal Birger <eyal.birger@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        pravin shelar <pshelar@....org>
Subject: Re: [PATCH net-next v2 1/3] openvswitch: normalize vlan rx path

On Wed, 5 Oct 2016 14:44:26 -0400, Eric Garver wrote:
> On Wed, Oct 05, 2016 at 08:31:52PM +0300, Eyal Birger wrote:
> > Just seemed less future safe to keep a pointer to an old packet lying around.
> 
> I agree. Alternatively refresh the eth pointer.

Sorry guys, that just doesn't make sense. Everyone should know that
reloading of skb pointer means the former pointers to its data may
become invalid. Please point me to any place in the kernel where we
reload the data pointer "just because" even when not used.

 Jiri