netdev - Re: [PATCH net] Fixing a bug in team driver due to incorrect 'unsigned int' to 'int' conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 06 Oct 2016 04:37:38 +0900
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Alex Sidorenko <alexandre.sidorenko@....com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] Fixing a bug in team driver due to incorrect
 'unsigned  int' to 'int' conversion

On Wed, 2016-10-05 at 09:06 -0400, Alex Sidorenko wrote:
> Roundrobin runner of team driver uses 'unsigned int' variable to count the number of sent_packets.
> Later it is passed to a subroutine team_num_to_port_index(struct team *team, int num) as
> 'num' and when we reach MAXINT (2**31-1), 'num' becomes negative.
> 
> This leads to using incorrect hash-bucket for port lookup and as a result, packets are dropped. The fix
> consists of changing 'int num' to 'unsigned int num'. Testing of a fixed kernel shows that there
> is no packet drop anymore.
> 
> 
> Signed-off-by: Alex Sidorenko <alexandre.sidorenko@....com>

Note that lines in your changelog are longer than the norm 
( Documentation/SubmittingPatches around line 619 )

 - The body of the explanation, line wrapped at 75 columns, which will
   be copied to the permanent changelog to describe this patch.

Otherwise, patch looks, welcome to the club Alex !

Acked-by: Eric Dumazet <edumazet@...gle.com>