netdev - Re: [PATCH] devicetree: net: micrel-ksz90x1.txt: Properly explain skew settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5c48a89f-3f2e-a74a-8e7b-a4b7397c2408@gmail.com>
Date:   Thu, 6 Oct 2016 04:04:26 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Mike Looijmans <mike.looijmans@...ic.nl>,
        devicetree@...r.kernel.org
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        davem@...emloft.net, robh+dt@...nel.org, mark.rutland@....com,
        andrew@...n.ch
Subject: Re: [PATCH] devicetree: net: micrel-ksz90x1.txt: Properly explain
 skew settings

On 10/05/2016 07:03 AM, Mike Looijmans wrote:
> The KSZ9031 skew registers contain an offset, the chip's default value
> is "neutral" which does not add any skew. Programming a 0 into a skew
> property will actually set it the maximal negative adjustment and not
> to a neutral position as one would expect.
> 
> Explain this situation in the devicetree binding documentation and list
> the settings that the chip considers neutral.
> 
> Changing the implementation to accept negative values would have been
> a better solution, but would break existing configurations.
> 
> Signed-off-by: Mike Looijmans <mike.looijmans@...ic.nl>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

Thanks!
-- 
Florian