netdev - Re: [PATCH net] packet: call fanout_release, while UNREGISTERING a netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20161006.205052.1380596858044266995.davem@davemloft.net>
Date:   Thu, 06 Oct 2016 20:50:52 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     anoob.soman@...rix.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] packet: call fanout_release, while UNREGISTERING a
 netdev

From: Anoob Soman <anoob.soman@...rix.com>
Date: Wed, 5 Oct 2016 15:12:54 +0100

> If a socket has FANOUT sockopt set, a new proto_hook is registered
> as part of fanout_add(). When processing a NETDEV_UNREGISTER event in
> af_packet, __fanout_unlink is called for all sockets, but prot_hook which was
> registered as part of fanout_add is not removed. Call fanout_release, on a
> NETDEV_UNREGISTER, which removes prot_hook and removes fanout from the
> fanout_list.
> 
> This fixes BUG_ON(!list_empty(&dev->ptype_specific)) in netdev_run_todo()
> 
> Signed-off-by: Anoob Soman <anoob.soman@...rix.com>

Applied and queued up for -stable, thanks.