netdev - Re: [PATCH] net: macb: NULL out phydev after removing mdio bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161007.235718.1329800164848117692.davem@davemloft.net>
Date:   Fri, 07 Oct 2016 23:57:18 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     xander.huff@...com
Cc:     nicolas.ferre@...el.com, netdev@...r.kernel.org,
        nathan.sullivan@...com, linux-kernel@...r.kernel.org,
        brad.mouring@...com
Subject: Re: [PATCH] net: macb: NULL out phydev after removing mdio bus

From: Xander Huff <xander.huff@...com>
Date: Fri, 7 Oct 2016 10:13:22 -0500

> From: Nathan Sullivan <nathan.sullivan@...com>
> 
> To ensure the dev->phydev pointer is not used after becoming invalid in
> mdiobus_unregister, set it to NULL. This happens when removing the macb
> driver without first taking its interface down, since unregister_netdev
> will end up calling macb_close.
> 
> Signed-off-by: Xander Huff <xander.huff@...com>
> Signed-off-by: Nathan Sullivan <nathan.sullivan@...com>
> Signed-off-by: Brad Mouring <brad.mouring@...com>

Applied.