lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 9 Oct 2016 11:10:11 +0200 From: Phil Sutter <phil@....cc> To: Hangbin Liu <liuhangbin@...il.com> Cc: netdev@...r.kernel.org, Stephen Hemminger <stephen@...workplumber.org> Subject: Re: [PATCH iproute2] devlink: Convert conditional in dl_argv_handle_port() to switch() On Sun, Oct 09, 2016 at 10:14:18AM +0800, Hangbin Liu wrote: > Discovered by Phil's covscan. The final return statement is never reached. > This is not inherently clear from looking at the code, so change the > conditional to a switch() statement which should clarify this. > > CC: Phil Sutter <phil@....cc> > Signed-off-by: Hangbin Liu <liuhangbin@...il.com> Acked-by: Phil Sutter <phil@....cc>
Powered by blists - more mailing lists