[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Mon, 10 Oct 2016 03:17:24 -0400 (EDT)
From: David Miller <davem@...emloft.net>
To: Yuval.Mintz@...ium.com
Cc: eric.dumazet@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 5/6] qed: Allow chance for fast ramrod
completions
From: "Mintz, Yuval" <Yuval.Mintz@...ium.com>
Date: Mon, 10 Oct 2016 06:33:05 +0000
>
>> > + while (iter_cnt--) {
>> > + /* Validate we receive completion update */
>> > smp_rmb();
>> > if (comp_done->done == 1) {
>> > if (p_fw_ret)
>> > *p_fw_ret = comp_done->fw_return_code;
>> > return 0;
>> > }
>
>> Note that this smp_rmb() and accesses to ->done and ->fw_return_code are
>> racy.
>
>> fw_return_code needs to be written _before_ done.
>
> Thanks for catching this up.
>
> Dave - do you want me to re-spin for this?
Yes.
Powered by blists - more mailing lists