netdev - Re: [PATCH v5 3/4] cfg80211: configure multicast to unicast for AP interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1476095313.7895.12.camel@sipsolutions.net>
Date:   Mon, 10 Oct 2016 12:28:33 +0200
From:   Johannes Berg <johannes@...solutions.net>
To:     Michael Braun <michael-dev@...i-braun.de>
Cc:     linux-wireless@...r.kernel.org, projekt-wlan@....tu-ilmenau.de,
        netdev@...r.kernel.org
Subject: Re: [PATCH v5 3/4] cfg80211: configure multicast to unicast for AP
 interfaces


>   *
> + * @NL80211_ATTR_MULTICAST_TO_UNICAST_ENABLED: Multicast packets
> should be
> + *      send out as unicast to all stations.

You should document what type of attribute is expected. You probably
wanted a flag attribute, but ...

> +	[NL80211_ATTR_MULTICAST_TO_UNICAST_ENABLED] = { .type =
> NLA_U8, },

have u8 in the policy, yet

> +	enabled = nla_get_flag(nla);

actually use as a flag :)


In addition to that, I think you should clarify the "per-BSS" comment
in nl80211, and also clarify (at the same place) what kind of
functionality is expected from this.

johannes