netdev - Re: [RFC v3 3/3] phy,leds: add support for led triggers on phy link state change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161011205646.GG14094@lunn.ch>
Date:   Tue, 11 Oct 2016 22:56:46 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     Zach Brown <zach.brown@...com>, mlindner@...vell.com,
        stephen@...workplumber.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
        florian.c.schilhabel@...glemail.com, Larry.Finger@...inger.net,
        gregkh@...uxfoundation.org, rpurdie@...ys.net,
        j.anaszewski@...sung.com, linux-leds@...r.kernel.org
Subject: Re: [RFC v3 3/3] phy,leds: add support for led triggers on phy link
 state change

> Andrew, are you happy with this implementation?

Sorry, been to busy with other things to follow the discussion.

What would be nice to see is a comment about how the link to LEDs in
the PHYs is made. Often there is a couple of LEDs in the RJ45 socket
driven by the PHY. They can show link, speed, packet Rx/Tx, etc. How
are these triggers related to these LEDs?

    Andrew