lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 12 Oct 2016 21:55:00 +0200 From: Andrew Lunn <andrew@...n.ch> To: Kyle Roeschley <kyle.roeschley@...com> Cc: Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [RFC] net: phy: smsc: Disable auto-negotiation on startup On Wed, Oct 12, 2016 at 10:05:33AM -0500, Kyle Roeschley wrote: > On Wed, Oct 12, 2016 at 02:13:06AM -0700, Florian Fainelli wrote: > > On 10/10/2016 10:41 AM, Kyle Roeschley wrote: > > > Because the SMSC PHY completes auto-negotiation before the driver is > > > ready to handle interrupts, the PHY state machine never realizes that we > > > have a link. Clear the ANENABLE bit on initialization, which lets > > > genphy_config_aneg do its thing when that code is hit later. > > > > > > While this patch does fix the problem we see (no link on boot without > > > re-plugging the cable), it seems like the generic PHY code should be > > > able to handle auto-negotiation completing before interrupts are > > > enabled. Submitted as an RFC in the hopes that someone has an idea as to > > > how that could be done. > > > > > > This fix is copied from commit 99f81afc139c ("phy: micrel: Disable auto > > > negotiation on startup"). > > > > Do you mind trying: > > > > https://www.spinics.net/lists/netdev/msg397857.html > > > > and see if you do get link interrupts without your patch applied? Thanks! > > Yep, that fixes it. I figured there was some state machine issue I was missing. > Thanks very much! Humm, O.K, time to pull that patch out of the series and make it standalone. Andrew
Powered by blists - more mailing lists