netdev - Re: [PATCHv1 net] xen-netback: fix guest Rx stall detection (after guest Rx refactor)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161013.102114.277377641513965761.davem@davemloft.net>
Date:   Thu, 13 Oct 2016 10:21:14 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     david.vrabel@...rix.com
Cc:     netdev@...r.kernel.org, xen-devel@...ts.xenproject.org,
        paul.durrant@...rix.com, wei.liu2@...rix.com
Subject: Re: [PATCHv1 net] xen-netback: fix guest Rx stall detection (after
 guest Rx refactor)

From: David Vrabel <david.vrabel@...rix.com>
Date: Tue, 11 Oct 2016 16:48:27 +0100

> If a VIF has been ready for rx_stall_timeout (60s by default) and an
> Rx ring is drained of all requests an Rx stall will be incorrectly
> detected.  When this occurs and the guest Rx queue is empty, the Rx
> ring's event index will not be set and the frontend will not raise an
> event when new requests are placed on the ring, permanently stalling
> the VIF.
> 
> This is a regression introduced by eb1723a29b9a7 (xen-netback:
> refactor guest rx).
> 
> Fix this by reinstating the setting of queue->last_rx_time when
> placing a packet onto the guest Rx ring.
> 
> Signed-off-by: David Vrabel <david.vrabel@...rix.com>

Applied.