netdev - Re: [PATCH v4 3/3] net: phy: leds: add support for led triggers on phy link state change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20161013.104634.2079376697690971907.davem@davemloft.net>
Date:   Thu, 13 Oct 2016 10:46:34 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     zach.brown@...com
Cc:     f.fainelli@...il.com, mlindner@...vell.com,
        stephen@...workplumber.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
        florian.c.schilhabel@...glemail.com, Larry.Finger@...inger.net,
        gregkh@...uxfoundation.org, rpurdie@...ys.net,
        j.anaszewski@...sung.com, linux-leds@...r.kernel.org,
        andrew@...n.ch
Subject: Re: [PATCH v4 3/3] net: phy: leds: add support for led triggers on
 phy link state change

From: Zach Brown <zach.brown@...com>
Date: Tue, 11 Oct 2016 15:26:20 -0500

> From: Josh Cartwright <josh.cartwright@...com>
> 
> Create an option CONFIG_LED_TRIGGER_PHY (default n), which will
> create a set of led triggers for each instantiated PHY device.  There is
> one LED trigger per link-speed, per-phy.
> 
> This allows for a user to configure their system to allow a set of LEDs
> to represent link state changes on the phy.
> 
> Signed-off-by: Josh Cartwright <josh.cartwright@...com>
> Signed-off-by: Nathan Sullivan <nathan.sullivan@...com>
> Signed-off-by: Zach Brown <zach.brown@...com>
 ...
> +	static const char * const name_suffix[] = {
> +		"10Mbps",
> +		"100Mbps",
> +		"1Gbps",
> +		"2.5Gbps",
> +		"10Gbps",

This choice of both the array size and the speeds to support seems
entirely arbitrary and is inappropriate for a generic driver of this
kind.

This seems to be hard coding this to support the list of speeds
supported by whatever driver you want to use with this new LED
facility, and sorry that's not how we build nice generic pieces of
infrastructure.

Thanks.