netdev - Re: [PATCH net] Revert "net: Add driver helper functions to determine checksum offloadability"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7e5fd685-1ff8-c030-ac44-eaed040b5cea@solarflare.com>
Date:   Thu, 13 Oct 2016 16:31:41 +0100
From:   Jonathan Cooper <jcooper@...arflare.com>
To:     David Miller <davem@...emloft.net>, <stephen@...workplumber.org>
CC:     <tom@...bertland.com>, <netdev@...r.kernel.org>
Subject: Re: [PATCH net] Revert "net: Add driver helper functions to determine
 checksum offloadability"

On 13/10/16 15:35, David Miller wrote:
> From: Stephen Hemminger <stephen@...workplumber.org>
> Date: Tue, 11 Oct 2016 13:04:09 -0700
>
>> This reverts commit 6ae23ad36253a8033c5714c52b691b84456487c5.
>>
>> The code has been in kernel since 4.4 but there are no in tree
>> code that uses. Unused code is broken code, remove it.
>>
>> Signed-off-by: Stephen Hemminger <stephen@...workplumber.org>
> Tom if you have any real plans to develop on this work at all in
> the immediate future, please speak up now.
>
> Otherwise I'm applying Stephen's patch.
>
> Thanks.

Oops, nope, I tell a lie. We used it initially and then realised we 
didn't strictly
need it since we only advertise IP_CSUM and IPV6_CSUM of inner
packets, so we should never be presented with a packet we'd need to
call the helper for. So we're not using it after all.

Jon