netdev - Re: [PATCH v4 net-next 3/4] net/sched: tc_mirred: Rename public predicates 'is_tcf_mirred_redirect' and 'is_tcf_mirred

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e602a620-d4f9-6788-eca4-a666966a9448@mojatatu.com>
Date:   Thu, 13 Oct 2016 07:57:06 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Shmulik Ladkani <shmulik.ladkani@...il.com>,
        David Miller <davem@...emloft.net>
Cc:     Eric Dumazet <edumazet@...gle.com>,
        WANG Cong <xiyou.wangcong@...il.com>,
        Daniel Borkmann <daniel@...earbox.net>, netdev@...r.kernel.org,
        Hariprasad S <hariprasad@...lsio.com>,
        Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
        Saeed Mahameed <saeedm@...lanox.com>,
        Jiri Pirko <jiri@...lanox.com>,
        Ido Schimmel <idosch@...lanox.com>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>
Subject: Re: [PATCH v4 net-next 3/4] net/sched: tc_mirred: Rename public
 predicates 'is_tcf_mirred_redirect' and 'is_tcf_mirred_mirror'

On 16-10-13 02:06 AM, Shmulik Ladkani wrote:
> These accessors are used in various drivers that support tc offloading,
> to detect properties of a given 'tc_action'.
>
> 'is_tcf_mirred_redirect' tests that the action is TCA_EGRESS_REDIR.
> 'is_tcf_mirred_mirror' tests that the action is TCA_EGRESS_MIRROR.
>
> As a prep towards supporting INGRESS redir/mirror, rename these
> predicates to reflect their true meaning:
>   s/is_tcf_mirred_redirect/is_tcf_mirred_egress_redirect/
>   s/is_tcf_mirred_mirror/is_tcf_mirred_egress_mirror/
>
> Signed-off-by: Shmulik Ladkani <shmulik.ladkani@...il.com>

Acked-by: Jamal Hadi Salim <jhs@...atatu.com>

cheers,
jamal