netdev - Re: [PATCH] vmxnet3: avoid assumption about invalid dma_pa in vmxnet3_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20161013.094323.1769619439752576215.davem@davemloft.net>
Date:   Thu, 13 Oct 2016 09:43:23 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     khoroshilov@...ras.ru
Cc:     skhare@...are.com, pv-drivers@...are.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, ldv-project@...uxtesting.org
Subject: Re: [PATCH] vmxnet3: avoid assumption about invalid dma_pa in
 vmxnet3_set_mc()

From: Alexey Khoroshilov <khoroshilov@...ras.ru>
Date: Fri,  7 Oct 2016 22:53:43 -0400

> vmxnet3_set_mc() still assumes zero is invalid pa:
>   it assumes dma_mapping_error(...,0) returns true if vmxnet3_copy_mc() fails;
>   it calls dma_unmap_single() iff new_table_pa is not zero.
> 
> The patch adds an explicit variable to track status of new_table_pa.
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Alexey Khoroshilov <khoroshilov@...ras.ru>

Please use "bool" and "true"/"false" for boolean variables.

Thanks.