netdev - Re: [PATCH 1/2] IPv6: Drop the temporary address regen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161014.105933.75588707766999077.davem@davemloft.net>
Date:   Fri, 14 Oct 2016 10:59:33 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     jbohac@...e.cz
Cc:     kuznet@....inr.ac.ru, jmorris@...ei.org, yoshfuji@...ux-ipv6.org,
        kaber@...sh.net, netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] IPv6: Drop the temporary address regen_timer

From: Jiri Bohac <jbohac@...e.cz>
Date: Thu, 13 Oct 2016 18:50:02 +0200

> The randomized interface identifier (rndid) was periodically updated from
> the regen_timer timer. Simplify the code by updating the rndid only when
> needed by ipv6_try_regen_rndid().
> 
> This makes the follow-up DESYNC_FACTOR fix much simpler.  Also it fixes a
> reference counting error in this error path, where an in6_dev_put was
> missing:
> 		err = addrconf_sysctl_register(ndev);
> 		if (err) {
> 			ipv6_mc_destroy_dev(ndev);
> 	-               del_timer(&ndev->regen_timer);
> 			snmp6_unregister_dev(ndev);
> 			goto err_release;
> 
> Signed-off-by: Jiri Bohac <jbohac@...e.cz>

Applied.