netdev - Re: [PATCH trivial] net: add bbr to config DEFAULT_TCP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161014.111727.1347759995128120612.davem@davemloft.net>
Date:   Fri, 14 Oct 2016 11:17:27 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     markus@...ppelsdorf.de
Cc:     eric.dumazet@...il.com, ncardwell@...gle.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH trivial] net: add bbr to config DEFAULT_TCP_CONG

From: Markus Trippelsdorf <markus@...ppelsdorf.de>
Date: Fri, 14 Oct 2016 10:07:16 +0200

> On 2016.10.14 at 09:43 +0200, Eric Dumazet wrote:
>> On Fri, 2016-10-14 at 09:33 +0200, Markus Trippelsdorf wrote:
>> > While playing with BBR I noticed that it was missing in the list of
>> > possible config DEFAULT_TCP_CONG choices. Fixed thusly.
>> > 
>> > Signed-off-by: Markus Trippelsdorf <markus@...ppelsdorf.de>
>> > 
>> > diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
>> > index 300b06888fdf..b54b3ca939db 100644
>> > --- a/net/ipv4/Kconfig
>> > +++ b/net/ipv4/Kconfig
>> > @@ -715,6 +715,7 @@ config DEFAULT_TCP_CONG
>> >  	default "reno" if DEFAULT_RENO
>> >  	default "dctcp" if DEFAULT_DCTCP
>> >  	default "cdg" if DEFAULT_CDG
>> > +	default "bbr" if DEFAULT_BBR
>> >  	default "cubic"
>> 
>> Not sure if we want this at this moment.
>> 
>> BBR needs FQ packet scheduler, and this is not exactly trivial to
>> achieve.
> 
> For a start, it could be automatically selected:

Right but FQ has to be properly enabled and configured as well.