netdev - Re: [PATCH trivial] net: add bbr to config DEFAULT_TCP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1476431026.5650.38.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Fri, 14 Oct 2016 09:43:46 +0200
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Markus Trippelsdorf <markus@...ppelsdorf.de>
Cc:     Neal Cardwell <ncardwell@...gle.com>, netdev@...r.kernel.org
Subject: Re: [PATCH trivial] net: add bbr to config DEFAULT_TCP_CONG

On Fri, 2016-10-14 at 09:33 +0200, Markus Trippelsdorf wrote:
> While playing with BBR I noticed that it was missing in the list of
> possible config DEFAULT_TCP_CONG choices. Fixed thusly.
> 
> Signed-off-by: Markus Trippelsdorf <markus@...ppelsdorf.de>
> 
> diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
> index 300b06888fdf..b54b3ca939db 100644
> --- a/net/ipv4/Kconfig
> +++ b/net/ipv4/Kconfig
> @@ -715,6 +715,7 @@ config DEFAULT_TCP_CONG
>  	default "reno" if DEFAULT_RENO
>  	default "dctcp" if DEFAULT_DCTCP
>  	default "cdg" if DEFAULT_CDG
> +	default "bbr" if DEFAULT_BBR
>  	default "cubic"

Not sure if we want this at this moment.

BBR needs FQ packet scheduler, and this is not exactly trivial to
achieve.