netdev - Re: [PATCH net-next 1/2] lwtunnel: Add destroy state operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161014105948.2a53c2cd@griffin>
Date:   Fri, 14 Oct 2016 10:59:47 +0200
From:   Jiri Benc <jbenc@...hat.com>
To:     Tom Herbert <tom@...bertland.com>
Cc:     <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <roopa@...ulusnetworks.com>, <kernel-team@...com>
Subject: Re: [PATCH net-next 1/2] lwtunnel: Add destroy state operation

On Thu, 13 Oct 2016 17:57:42 -0700, Tom Herbert wrote:
> @@ -43,13 +44,11 @@ struct lwtunnel_encap_ops {
>  	int (*get_encap_size)(struct lwtunnel_state *lwtstate);
>  	int (*cmp_encap)(struct lwtunnel_state *a, struct lwtunnel_state *b);
>  	int (*xmit)(struct sk_buff *skb);
> +	void (*destroy_state)(struct lwtunnel_state *lws);
>  };

Could you add destroy_state next to build_state? Seems weird to have
those two scattered at the opposite ends of the structure. Looks good
otherwise.

Thanks,

 Jiri