netdev - Re: linux/atm_zatm.h not really usable in userspace since cf00713a655d3019be7faa184402f16c43a0fed3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161015140906.GC2831@lakka.kapsi.fi>
Date:   Sat, 15 Oct 2016 17:09:06 +0300
From:   Mikko Rapeli <mikko.rapeli@....fi>
To:     Pascal Terjan <pterjan@...il.com>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: linux/atm_zatm.h not really usable in userspace since
 cf00713a655d3019be7faa184402f16c43a0fed3

On Sat, Oct 15, 2016 at 01:05:10PM +0100, Pascal Terjan wrote:
> It is no longer possible to include <linux/atm_zatm.h> + userspace
> headers using time, for example  <stdlib.h>, this broke for example
> the build of linux-atm.
> 
> Reproducer:
> 
> $ cat test.c
> #include <linux/atm_zatm.h>
> #include <stdlib.h>

If possible, please reverse the order of includes to first include glibc
headers and then Linux kernel uapi ones.

Kernel uapi headers did not declare their header file dependencies correctly
and I've been fixing them. I have also tried to fix compatibility issues
with glibc headers, but unfortunately they only work when glibc headers
are included before kernel headers. Userspace which has been relying on
the magic include order for various uapi headers is now unfortunately
affected. Sorry about that.

-Mikko

> $ gcc -c test.c
> In file included from /usr/include/sys/select.h:43:0,
>                  from /usr/include/sys/types.h:219,
>                  from /usr/include/stdlib.h:314,
>                  from test.c:2:
> /usr/include/time.h:120:8: error: redefinition of 'struct timespec'
>  struct timespec
>         ^
> In file included from /usr/include/linux/atm_zatm.h:17:0,
>                  from test.c:1:
> /usr/include/linux/time.h:9:8: note: originally defined here
>  struct timespec {
>         ^
> In file included from /usr/include/sys/select.h:45:0,
>                  from /usr/include/sys/types.h:219,
>                  from /usr/include/stdlib.h:314,
>                  from test.c:2:
> /usr/include/bits/time.h:30:8: error: redefinition of 'struct timeval'
>  struct timeval
>         ^
> In file included from /usr/include/linux/atm_zatm.h:17:0,
>                  from test.c:1:
> /usr/include/linux/time.h:15:8: note: originally defined here
>  struct timeval {
>         ^