netdev - Re: [PATCH v2] vmxnet3: avoid assumption about invalid dma_pa in vmxnet3_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161015.174825.2149332278069508221.davem@davemloft.net>
Date:   Sat, 15 Oct 2016 17:48:25 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     khoroshilov@...ras.ru
Cc:     skhare@...are.com, pv-drivers@...are.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, ldv-project@...uxtesting.org
Subject: Re: [PATCH v2] vmxnet3: avoid assumption about invalid dma_pa in
 vmxnet3_set_mc()

From: Alexey Khoroshilov <khoroshilov@...ras.ru>
Date: Sat, 15 Oct 2016 00:01:20 +0300

> vmxnet3_set_mc() checks new_table_pa returned by dma_map_single()
> with dma_mapping_error(), but even there it assumes zero is invalid pa
> (it assumes dma_mapping_error(...,0) returns true if new_table is NULL).
> 
> The patch adds an explicit variable to track status of new_table_pa.
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> v2: use "bool" and "true"/"false" for boolean variables.
> Signed-off-by: Alexey Khoroshilov <khoroshilov@...ras.ru>

Applied.