lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 17 Oct 2016 16:35:10 +0100 From: Måns Rullgård <mans@...sr.com> To: Wei Yongjun <weiyj.lk@...il.com> Cc: jarod@...hat.com, sf84@...oste.net, peter.chen@....com, tremyfr@...il.com, arnd@...db.de, f.fainelli@...il.com, Wei Yongjun <weiyongjun1@...wei.com>, netdev@...r.kernel.org Subject: Re: [PATCH -next] net: ethernet: nb8800: fix error return code in nb8800_open() Wei Yongjun <weiyj.lk@...il.com> writes: > From: Wei Yongjun <weiyongjun1@...wei.com> > > Fix to return error code -ENODEV from the of_phy_connect() error > handling case instead of 0, as done elsewhere in this function. > > Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com> Acked-by: Mans Rullgard <mans@...sr.com> > --- > drivers/net/ethernet/aurora/nb8800.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/aurora/nb8800.c b/drivers/net/ethernet/aurora/nb8800.c > index 453dc09..99c4055 100644 > --- a/drivers/net/ethernet/aurora/nb8800.c > +++ b/drivers/net/ethernet/aurora/nb8800.c > @@ -975,8 +975,10 @@ static int nb8800_open(struct net_device *dev) > phydev = of_phy_connect(dev, priv->phy_node, > nb8800_link_reconfigure, 0, > priv->phy_mode); > - if (!phydev) > + if (!phydev) { > + err = -ENODEV; > goto err_free_irq; > + } > > nb8800_pause_adv(dev); > -- Måns Rullgård
Powered by blists - more mailing lists