netdev - Re: [PATCH net] bnx2: fix locking when netconsole is used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20161017.132142.526817621160813690.davem@davemloft.net>
Date:   Mon, 17 Oct 2016 13:21:42 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     ivecera@...hat.com
Cc:     netdev@...r.kernel.org, sony.chacko@...gic.com,
        Dept-HSGLinuxNICDev@...gic.com
Subject: Re: [PATCH net] bnx2: fix locking when netconsole is used

From: Ivan Vecera <ivecera@...hat.com>
Date: Mon, 17 Oct 2016 18:20:31 +0200

> diff --git a/drivers/net/ethernet/broadcom/bnx2.c b/drivers/net/ethernet/broadcom/bnx2.c
> index 27f11a5..9c408413 100644
> --- a/drivers/net/ethernet/broadcom/bnx2.c
> +++ b/drivers/net/ethernet/broadcom/bnx2.c
> @@ -272,21 +272,24 @@ static u32
>  bnx2_reg_rd_ind(struct bnx2 *bp, u32 offset)
>  {
>  	u32 val;
> +	unsigned long flags;
>  

Please order local variable declarations from longest to shortest
line.

Thank you.