lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <4f9d6820-d3c4-ea90-8b3a-b6d4f5911580@osg.samsung.com> Date: Mon, 17 Oct 2016 17:38:02 -0300 From: Javier Martinez Canillas <javier@....samsung.com> To: Wei Yongjun <weiyj.lk@...il.com>, Zhao Qiang <qiang.zhao@....com> Cc: Wei Yongjun <weiyongjun1@...wei.com>, netdev@...r.kernel.org Subject: Re: [PATCH -next] net: wan: slic_ds26522: Use module_spi_driver to simplify the code Hello Wei, On 10/17/2016 11:50 AM, Wei Yongjun wrote: > From: Wei Yongjun <weiyongjun1@...wei.com> > > module_spi_driver() makes the code simpler by eliminating > boilerplate code. > > Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com> > --- > drivers/net/wan/slic_ds26522.c | 13 +------------ > 1 file changed, 1 insertion(+), 12 deletions(-) > > diff --git a/drivers/net/wan/slic_ds26522.c b/drivers/net/wan/slic_ds26522.c > index b776a0a..8f782f1 100644 > --- a/drivers/net/wan/slic_ds26522.c > +++ b/drivers/net/wan/slic_ds26522.c > @@ -249,15 +249,4 @@ static struct spi_driver slic_ds26522_driver = { > .id_table = slic_ds26522_id, > }; > > -static int __init slic_ds26522_init(void) > -{ > - return spi_register_driver(&slic_ds26522_driver); > -} > - > -static void __exit slic_ds26522_exit(void) > -{ > - spi_unregister_driver(&slic_ds26522_driver); > -} > - > -module_init(slic_ds26522_init); > -module_exit(slic_ds26522_exit); > +module_spi_driver(slic_ds26522_driver); > Reviewed-by: Javier Martinez Canillas <javier@....samsung.com> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America
Powered by blists - more mailing lists