lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1476691113.3880.37.camel@coelho.fi> Date: Mon, 17 Oct 2016 10:58:33 +0300 From: Luca Coelho <luca@...lho.fi> To: David Binderman <dcb314@...mail.com>, "johannes.berg@...el.com" <johannes.berg@...el.com>, "emmanuel.grumbach@...el.com" <emmanuel.grumbach@...el.com>, "linuxwifi@...el.com" <linuxwifi@...el.com>, "kvalo@...eaurora.org" <kvalo@...eaurora.org>, "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: linux-4.9-rc1/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c:1561: poor error checking ? Hi David, On Mon, 2016-10-17 at 07:40 +0000, David Binderman wrote: > Hello there, > > linux-4.9-rc1/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c:1561]: (style) Checking if unsigned variable 'len' is less than zero. > > Source code is > > len = min((size_t)le32_to_cpu(rsp->len) << 2, > iwl_rx_packet_payload_len(hcmd.resp_pkt) - sizeof(*rsp)); > len = min(len - delta, count); > if (len < 0) { > ret = -EFAULT; > goto out; > } > > Suggest improve error checking. Thanks for reporting! A fix for this is already queued in our internal tree and will be sent upstream soon. -- Cheers, Luca.
Powered by blists - more mailing lists