lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <yw1xr37fkqxy.fsf@unicorn.mansr.com> Date: Mon, 17 Oct 2016 15:09:29 +0100 From: Måns Rullgård <mans@...sr.com> To: Javier Martinez Canillas <javier@....samsung.com> Cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Jarod Wilson <jarod@...hat.com>, Arnd Bergmann <arnd@...db.de>, Sebastian Frias <sf84@...oste.net>, Florian Fainelli <f.fainelli@...il.com>, Philippe Reynes <tremyfr@...il.com> Subject: Re: [PATCH 2/7] net: ethernet: nb8800: Fix module autoload Javier Martinez Canillas <javier@....samsung.com> writes: > If the driver is built as a module, autoload won't work because the module > alias information is not filled. So user-space can't match the registered > device with the corresponding module. > > Export the module alias information using the MODULE_DEVICE_TABLE() macro. > > Before this patch: > > $ $ modinfo drivers/net/ethernet/aurora/nb8800.ko | grep alias > $ > > After this patch: > > $ modinfo drivers/net/ethernet/aurora/nb8800.ko | grep alias > alias: of:N*T*Csigma,smp8734-ethernetC* > alias: of:N*T*Csigma,smp8734-ethernet > alias: of:N*T*Csigma,smp8642-ethernetC* > alias: of:N*T*Csigma,smp8642-ethernet > alias: of:N*T*Caurora,nb8800C* > alias: of:N*T*Caurora,nb8800 > > Signed-off-by: Javier Martinez Canillas <javier@....samsung.com> Acked-by: Mans Rullgard <mans@...sr.com> > --- > > drivers/net/ethernet/aurora/nb8800.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/aurora/nb8800.c b/drivers/net/ethernet/aurora/nb8800.c > index 453dc0967125..d5f2ad1a5a30 100644 > --- a/drivers/net/ethernet/aurora/nb8800.c > +++ b/drivers/net/ethernet/aurora/nb8800.c > @@ -1357,6 +1357,7 @@ static const struct of_device_id nb8800_dt_ids[] = { > }, > { } > }; > +MODULE_DEVICE_TABLE(of, nb8800_dt_ids); > > static int nb8800_probe(struct platform_device *pdev) > { > -- -- Måns Rullgård
Powered by blists - more mailing lists