lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 18 Oct 2016 10:24:56 -0400 (EDT) From: David Miller <davem@...emloft.net> To: ivecera@...hat.com Cc: netdev@...r.kernel.org, sony.chacko@...gic.com, Dept-HSGLinuxNICDev@...gic.com Subject: Re: [PATCH net v2] bnx2: fix locking when netconsole is used From: Ivan Vecera <ivecera@...hat.com> Date: Tue, 18 Oct 2016 08:16:03 +0200 > Functions bnx2_reg_rd_ind(), bnx2_reg_wr_ind() and bnx2_ctx_wr() > can be called with IRQs disabled when netconsole is enabled. So they > should use spin_{,un}lock_irq{save,restore} instead of _bh variants. > > Example call flow: > bnx2_poll() > ->bnx2_poll_link() > ->bnx2_phy_int() > ->bnx2_set_remote_link() > ->bnx2_shmem_rd() > ->bnx2_reg_rd_ind() > -> spin_lock_bh(&bp->indirect_lock); > spin_unlock_bh(&bp->indirect_lock); > ... > -> __local_bh_enable_ip > > static inline void __local_bh_enable_ip(unsigned long ip) > WARN_ON_ONCE(in_irq() || irqs_disabled()); <<<<<< WARN > > Cc: Sony Chacko <sony.chacko@...gic.com> > Cc: Dept-HSGLinuxNICDev@...gic.com > Signed-off-by: Ivan Vecera <ivecera@...hat.com> Applied, thanks Ivan.
Powered by blists - more mailing lists